chore(ui5-avatar): migrate wdio tests to cypress #11817
Open
+490
−362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -306,3 +306,183 @@ describe("Fallback Logic", () => { | |||
| .should("have.class", "ui5-avatar-fallback-icon-hidden"); | |||
| }); | |||
| }); | |||
|
|
|||
| describe("Avatar", () => { | |||
| let sharedInputValue = 0; | |||
There was a problem hiding this comment.
We should no longer need to track events with inputs, with cypress we can create stubs and assert the stubs directly
Example:
cy.get("@avatar")
.then(avatar => {
avatar.get(0).addEventListener("ui5-click", cy.stub().as("clickStub"));
});
cy.get("@avatar")
.click();
cy.get("@clickStub")
.should("have.been.calledOnce");| beforeEach(() => { | ||
| cy.mount( | ||
| <div> | ||
| <Avatar id="myAvatar1"> |
There was a problem hiding this comment.
Defining every avatar in the beforeEach hook is making the test cases harder to read. Instead, define each avatar with its initial state directly in the mount phase of the test where it’s used.
If an avatar is needed across multiple tests, create a generic one with empty or minimal setup in beforeEach, and set its specific state during the test’s setup phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Avatar and AvatarGroup tests to Cypress component tests while maintaining test coverage and functionality parity with original specs.
JIRA: BGSOFUIPIRIN-6816